From 938ca6d786a22065d938bcceadcb6ef9aea6b206 Mon Sep 17 00:00:00 2001
From: June <june@jsts.xyz>
Date: Tue, 18 Feb 2025 02:59:00 +0100
Subject: [PATCH] nginx(role): remove unnecessary apt-get update step
The nginx package gets installed with "update_cache: true" afterwards
anyway, so the apt-get update step shouldn't be necessary.
---
roles/nginx/handlers/main.yaml | 5 -----
roles/nginx/tasks/main/repo_setup.yaml | 6 ------
2 files changed, 11 deletions(-)
diff --git a/roles/nginx/handlers/main.yaml b/roles/nginx/handlers/main.yaml
index bc420db..57e07fc 100644
--- a/roles/nginx/handlers/main.yaml
+++ b/roles/nginx/handlers/main.yaml
@@ -3,8 +3,3 @@
name: nginx.service
state: restarted
become: true
-
-- name: apt-get update
- ansible.builtin.apt:
- update_cache: true
- become: true
diff --git a/roles/nginx/tasks/main/repo_setup.yaml b/roles/nginx/tasks/main/repo_setup.yaml
index 9edc156..253beb1 100644
--- a/roles/nginx/tasks/main/repo_setup.yaml
+++ b/roles/nginx/tasks/main/repo_setup.yaml
@@ -18,21 +18,18 @@
owner: root
group: root
become: true
- notify: apt-get update
- name: make sure NGINX APT repository is added
ansible.builtin.apt_repository:
repo: "deb [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/nginx.asc] https://nginx.org/packages/debian/ {{ ansible_distribution_release }} nginx"
state: present
become: true
- notify: apt-get update
- name: make sure NGINX APT source repository is added
ansible.builtin.apt_repository:
repo: "deb-src [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/nginx.asc] https://nginx.org/packages/debian/ {{ ansible_distribution_release }} nginx"
state: present
become: true
- notify: apt-get update
- name: set up repository pinning to make sure nginx package gets installed from NGINX repositories
ansible.builtin.copy:
@@ -46,6 +43,3 @@
group: root
mode: "0644"
become: true
-
-- name: Flush handlers to make sure "apt-get update" handler runs, if needed
- ansible.builtin.meta: flush_handlers