CCCHH/sunders
CCCHH/sunders
Watch
3
0
Fork
You've already forked sunders
 1
forked from kamba4/sunders
Code Issues 6 Pull requests Packages 1 Activity Actions

Fix security issues #38

Merged
stb merged 11 commits from security-fixes into main 2026-11-15 13:42:03 +01:00
Conversation 0 Commits 11 Files changed 7 +2 -2
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit cdf90a04d3 - Show all commits

fix: Corrects country code check in statistics filter
Some checks failed
Build (and tag) Images / build (push) Failing after 12s
Details

Prev Next 
Operator precedence made the check always true; it now accepts two capital letters or '--' as intended.
Stefan Bethke 2026-11-15 11:36:49 +01:00
commit cdf90a04d3

4
web/www/sunders/stats/index.php
View file

@ -84,8 +84,8 @@
} else {
$i18n = $i18nCountries;
$i18nDefault = $i18nCountriesDefault;
// Check if $key consists of 2 capital letters.
$key = preg_match('/\b[A-Z]{2}\b/', $valsArray[$i]) === 1 || '--' ? $valsArray[$i] : 'dontfindme';
// Check if $key consists of 2 capital letters or is '--' (unknown country).
$key = (preg_match('/^[A-Z]{2}$/', $valsArray[$i]) === 1 || $valsArray[$i] === '--') ? $valsArray[$i] : 'dontfindme';
}
if (!isValidValue($i18n, $i18nDefault, $key)) {
// ignore 'vals' and 'cols'