From 11b00783f8075957b243f08fdf0af45a007079fd Mon Sep 17 00:00:00 2001
From: Frieder Schrempf <dev@fris.de>
Date: Sun, 18 Apr 2021 16:14:08 +0200
Subject: [PATCH] Use direct links for sidebar elements with only a single
 subitem

If a sidebar toggler contains only a single item with a link, there
is no need to create a toggler with subnav at all. Let's just remove
the subnav and link to the target directly.

Signed-off-by: Frieder Schrempf <dev@fris.de>
---
 js/sidebar.js | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)

diff --git a/js/sidebar.js b/js/sidebar.js
index bb33be1..21cedfa 100644
--- a/js/sidebar.js
+++ b/js/sidebar.js
@@ -124,7 +124,6 @@ jQuery(function () {
                     ;
                 $toggler = jQuery('<div class="nav">').prepend($toggler);
 
-
                 // wrap all following siblings til the next element in a wrapper
                 var $wrap = jQuery('<div>')
                     .addClass('nav-panel');
@@ -136,20 +135,29 @@ jQuery(function () {
                     $sib.detach().appendTo($wrap);
                     addContentMenuCurrentStates($sib, $toggler);
                 }
-                $wrap.insertAfter($me);
+
+                /*
+                 * if there is only one subitem with a link, disable toggling
+                 * and use a direct link.
+                 */
+                var $links = jQuery($wrap[0]).find('a');
+                if ($links.length == 1) {
+                    $toggler.children().first().attr('href', jQuery($links[0]).attr('href'));
+                } else {
+                    $wrap.insertAfter($me);
+
+                    if ($toggler.parent('li').length) {
+                        $toggler.parent('li').addClass('toggler');
+                    }
+
+                    if (window.sessionStorage.getItem('sidebar-section-' + sidebarId + '-' + index + '-open') === 'true') {
+                        $wrap.css('display', 'block');
+                        setTogglerClass($toggler,'is-open');
+                    }
+                }
 
                 // replace element with toggler
                 $me.replaceWith($toggler);
-
-                if ($toggler.parent('li').length) {
-                    $toggler.parent('li').addClass('toggler');
-                }
-
-                if (window.sessionStorage.getItem('sidebar-section-' + sidebarId + '-' + index + '-open') === 'true') {
-                    $wrap.css('display', 'block');
-                    setTogglerClass($toggler,'is-open');
-                }
-
             });
 
             // fade in the navigation (was hidden until now
@@ -161,8 +169,10 @@ jQuery(function () {
          */
         initMenuHandling = function () {
             $nav.on('click', 'div.nav a', function (e) {
-                toggleNav(jQuery(this));
-                e.preventDefault();
+                if (jQuery(this).attr('href').startsWith('#')) {
+                    toggleNav(jQuery(this));
+                    e.preventDefault();
+                }
             });
         },