From 8b21589520ca94d2d2febed5cafa7af034af49dd Mon Sep 17 00:00:00 2001 From: Nils Schneider Date: Thu, 21 May 2015 17:57:02 +0200 Subject: [PATCH] infobox: fix image width of nodeInfo elements --- lib/infobox/node.js | 64 +++++++++++++++++++++++++-------------------- scss/main.scss | 10 +++++-- 2 files changed, 43 insertions(+), 31 deletions(-) diff --git a/lib/infobox/node.js b/lib/infobox/node.js index d7acf75..4c46c2f 100644 --- a/lib/infobox/node.js +++ b/lib/infobox/node.js @@ -134,34 +134,36 @@ define(["moment", "numeral", "tablesort", "tablesort.numeric"], } function showStatImg(o, nodeId) { - return function (el) { - var content, caption + var content, caption - if (o.thumbnail) { - content = document.createElement("img") - content.src = o.thumbnail.replace("{NODE_ID}", nodeId) - } - - if (o.caption) { - caption = o.caption.replace("{NODE_ID}", nodeId) - - if (!content) - content = document.createTextNode(caption) - } - - if (o.href) { - var link = document.createElement("a") - link.target = "_blank" - link.href = o.href.replace("{NODE_ID}", nodeId) - link.appendChild(content) - - if (caption && o.thumbnail) - link.title = caption - - el.appendChild(link) - } else - el.appendChild(content) + if (o.thumbnail) { + content = document.createElement("img") + content.src = o.thumbnail.replace("{NODE_ID}", nodeId) } + + if (o.caption) { + caption = o.caption.replace("{NODE_ID}", nodeId) + + if (!content) + content = document.createTextNode(caption) + } + + var p = document.createElement("p") + + if (o.href) { + var link = document.createElement("a") + link.target = "_blank" + link.href = o.href.replace("{NODE_ID}", nodeId) + link.appendChild(content) + + if (caption && o.thumbnail) + link.title = caption + + p.appendChild(link) + } else + p.appendChild(content) + + return p } return function(config, el, router, d) { @@ -193,13 +195,17 @@ define(["moment", "numeral", "tablesort", "tablesort.numeric"], attributeEntry(attributes, "Autom. Updates", showAutoupdate(d)) attributeEntry(attributes, "Clients", showClients(d)) + el.appendChild(attributes) + + if (config.nodeInfos) config.nodeInfos.forEach( function (nodeInfo) { - attributeEntry(attributes, nodeInfo.name, showStatImg(nodeInfo, d.nodeinfo.node_id)) + var h4 = document.createElement("h4") + h4.textContent = nodeInfo.name + el.appendChild(h4) + el.appendChild(showStatImg(nodeInfo, d.nodeinfo.node_id)) }) - el.appendChild(attributes) - if (d.neighbours.length > 0) { var h3 = document.createElement("h3") h3.textContent = "Nachbarknoten (" + d.neighbours.length + ")" diff --git a/scss/main.scss b/scss/main.scss index 4a032b3..ed7c629 100644 --- a/scss/main.scss +++ b/scss/main.scss @@ -212,8 +212,14 @@ button.close { padding-right: $buttondistance; } -.sidebar p, .sidebar table, .sidebar pre, .sidebar ul { - padding: 0 $buttondistance 1em; +.sidebar { + p, pre, ul, h4 { + padding: 0 $buttondistance 1em; + } + + table { + padding: 0 $buttondistance; + } } table {