• Germany & Cyberspace
  • Does infrastructure crimes with Nix and Ansible.

  • Joined on 2024-01-14
june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Just a nit-pick, but having the indentation be consistent across the dhcp4 and dhcp6 config would be nice.

june suggested changes for CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Core configuration looks good, tho I left some comments. Left some more comments on the roles as well.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

I would rather move the enable and start logic into the file itself, since that's not really the job of a handler. See the main unbound setup tasks for reference.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

There's no unbound-prometheus-exporter package on Debian.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Same comment as below: We already have a role for managing the resolv.conf, so rather include that.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

This seems to be using tabs for some reason, probably best to replace with spaces.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Same indentation problem here.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Same indentation problem here.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

"managment" -> "management"

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Is this still relevant on Debian? Again, we don't use Arch Linux in our infra.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Are those all the CPUs we use? Might it make sense to have this configurable or at least change the comment?

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

That's not what linting is for.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Called "reloaded" even tho the action is restarted. One of them needs to be adjusted.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Same restarted/reloaded comment as above.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

Same restarted/reloaded comment as above.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

We don't have any Arch Linux infrastructure, so we don't need this.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
WIP: new z9 ccchh router

We don't even have this role present in our repo, so just getting rid of the Arch Linux logic probably makes sense.

june pushed to main at CCCHH/ansible-infra 2026-05-23 22:41:50 +02:00
4574dbf4ba
secrets(role): introduce secrets role for storing secrets
june pushed to main at CCCHH/ansible-infra 2026-05-20 22:55:01 +02:00
51cd583dff
docs: move information on secrets and sops into docs
june pushed to main at CCCHH/ansible-infra 2026-05-20 20:10:11 +02:00
74fb99ec8f
docs: delete outdated section on web service setup from README