• Germany & Cyberspace
  • Does infrastructure crimes with Nix and Ansible.

  • Joined on 2024-01-14
june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

If we hardcode the version anyway, I think we should first check, if this version is already installed locally and only then hit the GitHub API. This avoids unnecessary steps and also avoids…

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

This sentence is now grammatically incorrect. Maybe: "Diverse VMs im z9 (PVE Cluster)"?

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I guess those commented out options can just be removed, if they aren't needed.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I think this handler isn't in use, is it?

june suggested changes for CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

Generally looks good and thanks for all the work!

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

This option isn't documented in the README.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I would still be in favor of just depending on our deploy_systemd_resolved_config role for managing this.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

If this isn't in use, it can just be removed.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

Some spacing seems to be off here.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

Some spacing seems to be off here as well.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

Same here with the resolver.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I'm not quite sure, if this is actually needed for resolving hostnames in the config. If everything works without the resolver config option, then lets just remove it.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

If all tasks are in the block, then this doesn't need to be a block.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I would just get rid of all the commented out options, if we don't use them anyway (and instead maybe link to a full-fledged config example from the docs or something).

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

I would rather remove this check and have it just fail while running the Ansible playbook, rather than installing a broken Kea deployment.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

Again, I think rather not having the checks makes more sense for our use case.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

This option isn't documented in the README.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

This option isn't documented in the README.

june commented on pull request CCCHH/ansible-infra#98 2026-08-02 02:05:42 +02:00
new z9 ccchh router

This option isn't documented in the README.