• Germany & Cyberspace
  • Does infrastructure crimes with Nix and Ansible.

  • Joined on 2024-01-14
june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

This seems to be using tabs for some reason, probably best to replace with spaces.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Same indentation problem here.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Same indentation problem here.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Is this still relevant on Debian? Again, we don't use Arch Linux in our infra.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

There is no bind package on Debian and we already install dig in the base_config role: 7832978ff7/roles…

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Again, same comment as in the kea role, I don't think it makes sense to have granular tags in the role itself.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Just a nit-pick, but having the indentation be consistent across the dhcp4 and dhcp6 config would be nice.

june suggested changes for CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Core configuration looks good, tho I left some comments. Left some more comments on the roles as well.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

We have a nice role for managing systemd-resolved already, so no need to duplicate functionality here.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Same comment as below: We already have a role for managing the resolv.conf, so rather include that.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

The search domain would be z9.ccchh.net. Unless it got decided to drop that now.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

I would rather just stick to only having tags at the playbook level. I don't think this kind granular control for the role is really needed as it the config files also shouldn't trigger a reload,…

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

If we configure ansible-pull variables above, the host should also be added to the relevant host group. (However an ansible-pull age private key is still missing.)

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Again, getting rid of the Arch Linux logic also greatly simplifies this file.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

I would rather move the enable and start logic into the file itself, since that's not really the job of a handler. See the main unbound setup tasks for reference.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Most of the variables here are commented out, so we can just massively simplify this file.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

It's fine, just feel like rt1 is one of those obscure names again, which gives more trouble than benefit.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

There's no unbound-prometheus-exporter package on Debian.

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

Do we have a requirement for the more up-to-date version present in the upstream repository or is the one in the Debian repos sufficient?

june commented on pull request CCCHH/ansible-infra#98 2026-05-24 18:49:42 +02:00
new z9 ccchh router

wireguard_wg55_privat_key -> wireguard_wg55_private_key