CCCHH/ansible-infra
CCCHH/ansible-infra
3
2
Fork 0
Code Issues2 Pull requests Wiki Activity Actions

dokuwiki: add ability to checkout custom theme repo #21

Closed
dario wants to merge 6 commits from eh22-wiki-design into main
Conversation 4 Commits 6 Files changed 3 -2
1 changed files with 0 additions and 2 deletions
Showing only changes of commit 0998111455 - Show all commits

2
roles/dokuwiki/tasks/main.yml
View file

@ -52,8 +52,6 @@
depth: 1
single_branch: true
track_submodules: true
accept_hostkey: true
accept_newhostkey: true
when:
- dokuwiki__custom_theme_git_url != ""
june marked this conversation as resolved
june commented 2025-02-17 21:02:22 +01:00
Review

Let's not do that, but encourage just using https://-clone URLs instead?

Let's not do that, but encourage just using `https://`-clone URLs instead?
dario commented 2025-02-17 21:06:28 +01:00
Review

yeah the hostkey stuff makes sense.
but single branch makes sense as a shallow copy of the repo is sufficient to apply the theme, and if a theme uses submodules, these need to be pulled in as well

yeah the hostkey stuff makes sense. but single branch makes sense as a shallow copy of the repo is sufficient to apply the theme, and if a theme uses submodules, these need to be pulled in as well
june commented 2025-02-17 21:07:16 +01:00
Review

Oh yeah ofc, I'm just talking about:

    accept_hostkey: true
    accept_newhostkey: true

Forgejo doesn't allow highlighting specific ranges, so it just picked four lines it seems. :/

Oh yeah ofc, I'm just talking about: ``` accept_hostkey: true accept_newhostkey: true ``` Forgejo doesn't allow highlighting specific ranges, so it just picked four lines it seems. :/
- dokuwiki__custom_theme_name != ""