CCCHH/ccchh-website
CCCHH/ccchh-website
3
3
Fork 2
Code Issues 3 Pull requests 6 Activity Actions

Resolve "Replace the default rss template" #18

Merged
echtnurich merged 0 commits from 3-replace-the-default-rss-template into main 2023-11-29 22:48:22 +01:00
Conversation 16 Commits - Files changed -
echtnurich commented 2023-11-08 22:39:04 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

Closes #3

Closes #3
echtnurich commented 2023-11-08 22:56:58 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 2 commits

  • f773870e - import default rss template
  • 575feb7f - change rss pubdate to lastmod

Compare with previous version

added 2 commits <ul><li>f773870e - import default rss template</li><li>575feb7f - change rss pubdate to lastmod</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=3980&start_sha=80a9b0a2d3f8d6802c4cbb0847c94df69ec2c276)
echtnurich commented 2023-11-08 23:06:21 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 1 commit

  • f2ffc2c7 - remove unused language code

Compare with previous version

added 1 commit <ul><li>f2ffc2c7 - remove unused language code</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=3981&start_sha=575feb7f43fc6fc04911ee9777e99f09887d4e8f)
echtnurich commented 2023-11-08 23:07:52 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 1 commit

  • f1d87b38 - *fix previous commit

Compare with previous version

added 1 commit <ul><li>f1d87b38 - *fix previous commit</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=3982&start_sha=f2ffc2c7a4aeb06d6abca6945c3b01656116dd69)
echtnurich commented 2023-11-08 23:12:54 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 1 commit

  • beccdca0 - put full articles in rss feed

Compare with previous version

added 1 commit <ul><li>beccdca0 - put full articles in rss feed</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=3984&start_sha=f1d87b38cc069380c4892baeaf034ab3b3f94e7e)
echtnurich commented 2023-11-08 23:23:22 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

marked this merge request as ready

marked this merge request as **ready**
echtnurich commented 2023-11-08 23:23:41 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

Sieht in meines RSS Client gut aus 👍

Sieht in meines RSS Client gut aus :thumbsup:
jtbx commented 2023-11-20 21:53:48 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

Warum war publishdate noch mal nicht OK, sodass du lastmod nutzt? Macht das Dinge kaputt, wenn Artikel aktualisiert werden?

Der Wert für lastmod ist in der hugo.toml definiert als folgende Präzedenzkette: [':git', ':fileModTime', 'lastmod', 'modified', 'publishdate', 'pubdate', 'published', 'date']. Ist das wirklich sinnvoll, dass das git-commit Datum und die filemod-Time einen expliziten Wert für lastmod überschreiben?

Warum war `publishdate` noch mal nicht OK, sodass du `lastmod` nutzt? Macht das Dinge kaputt, wenn Artikel aktualisiert werden? Der Wert für `lastmod` ist in der `hugo.toml` definiert als folgende Präzedenzkette: `[':git', ':fileModTime', 'lastmod', 'modified', 'publishdate', 'pubdate', 'published', 'date']`. Ist das wirklich sinnvoll, dass das git-commit Datum und die filemod-Time einen expliziten Wert für `lastmod` überschreiben?
jtbx commented 2023-11-20 22:03:11 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

Ich denke, folgende Einstellung in der Hugo.toml ist sinnvoller:

lastmod = ['lastmod', ':git', ':fileModTime', 'publishdate', 'date']

modified, pubdate und published sind übrigens keine "offiziellen" Frontmatter-Variablen, sondern einfach nur eine weitere Option für denselben Wert. Um konsistente Variablen zu fördern, würde ich Doppeldeutigkeiten gerne weglassen.

Ich denke, folgende Einstellung in der `Hugo.toml` ist sinnvoller: ```toml lastmod = ['lastmod', ':git', ':fileModTime', 'publishdate', 'date'] ``` `modified`, `pubdate` und `published` sind übrigens keine "offiziellen" Frontmatter-Variablen, sondern einfach nur eine weitere Option für denselben Wert. Um konsistente Variablen zu fördern, würde ich Doppeldeutigkeiten gerne weglassen.
jtbx commented 2023-11-29 22:40:10 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 4 commits

  • eb435623 - 1 commit from branch main
  • 198acc96 - settings: Fix lastmod fallback values
  • 7a7d073d - RSS: import default rss template
  • 45ad75eb - RSS: Put full articles in feed, use publishDate

Compare with previous version

added 4 commits <ul><li>eb435623 - 1 commit from branch <code>main</code></li><li>198acc96 - settings: Fix lastmod fallback values</li><li>7a7d073d - RSS: import default rss template</li><li>45ad75eb - RSS: Put full articles in feed, use publishDate</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=4028&start_sha=beccdca06d7071e418f01789240817528a1b7688)
jtbx commented 2023-11-29 22:45:28 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 1 commit

  • 6f57ac5e - Settings: RSS just for blog, but nothing else

Compare with previous version

added 1 commit <ul><li>6f57ac5e - Settings: RSS just for blog, but nothing else</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=4030&start_sha=45ad75eb7f98b3442ff25dd7502cc00a7f35911d)
jtbx commented 2023-11-29 22:45:36 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

resolved all threads

resolved all threads
jtbx commented 2023-11-29 22:46:22 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

added 3 commits

  • 634b0a87 - settings: RSS just for blog, but nothing else
  • 4dc04e83 - RSS: import default rss template
  • abf85cec - RSS: Put full articles in feed, use publishDate

Compare with previous version

added 3 commits <ul><li>634b0a87 - settings: RSS just for blog, but nothing else</li><li>4dc04e83 - RSS: import default rss template</li><li>abf85cec - RSS: Put full articles in feed, use publishDate</li></ul> [Compare with previous version](/ccchh/ccchh-website/-/merge_requests/14/diffs?diff_id=4032&start_sha=6f57ac5e6fe95919f0f192ce8ac4760276e593c0)
jtbx commented 2023-11-29 22:47:32 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

approved this merge request

approved this merge request
c6ristian commented 2023-11-29 22:47:46 +01:00 (Migrated from gitlab.hamburg.ccc.de)
Copy link

approved this merge request

approved this merge request
jtbx (Migrated from gitlab.hamburg.ccc.de) approved these changes 2024-01-16 20:06:47 +01:00
c6ristian (Migrated from gitlab.hamburg.ccc.de) approved these changes 2024-01-16 20:06:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
jtbx
c6ristian
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
CCCHH/ccchh-website!18
No description provided.