CCCHH/ccchh-website
CCCHH/ccchh-website
2
3
Fork 0
Code Issues 3 Pull requests 2 Activity Actions

Home: Add ellipsis to announcement summary #37

Merged
c6ristian merged 1 commit from feature/announcement-ellipsis into main 2024-03-06 19:35:02 +01:00
Conversation 1 Commits 1 Files changed 1 +3
jtbx commented 2024-01-27 15:18:52 +01:00
Owner
Copy link

TODO: How to add the ellipsis to pre-rendered summaries?

fixes #36

TODO: How to add the ellipsis to pre-rendered summaries? fixes #36
jtbx reviewed 2024-01-27 15:21:53 +01:00
themes/ccchh/layouts/index.html
@ -16,7 +16,7 @@
{{- if in .RawContent "<!--more-->" }}
{{ .Summary | safeHTML }}
jtbx commented 2024-01-27 15:21:53 +01:00
Author
Owner
Copy link

We need some ellipsis inside the paragraph here as well, but the {{ .Summary }} already has the closing </p> tag. Adding the ellipsis after the paragraph is kind of ugly.

We need some ellipsis inside the paragraph here as well, but the `{{ .Summary }}` already has the closing `</p>` tag. Adding the ellipsis after the paragraph is kind of ugly.
jtbx force-pushed feature/announcement-ellipsis from 310e7e3da5 to 372b24908a 2024-01-28 20:34:28 +01:00 Compare
jtbx commented 2024-01-28 20:35:28 +01:00
Author
Owner
Copy link

See https://staging.hamburg.ccc.de/pr37/

See https://staging.hamburg.ccc.de/pr37/
jtbx requested review from c6ristian 2024-02-10 19:36:28 +01:00
jtbx force-pushed feature/announcement-ellipsis from 372b24908a to 765d271531 2024-03-02 22:09:33 +01:00 Compare
c6ristian approved these changes 2024-03-06 19:34:45 +01:00
c6ristian merged commit 765d271531 into main 2024-03-06 19:35:02 +01:00
c6ristian deleted branch feature/announcement-ellipsis 2024-03-06 19:35:02 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
c6ristian
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: CCCHH/ccchh-website#37
No description provided.
Delete branch "feature/announcement-ellipsis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?