CCCHH/ccchh-website
CCCHH/ccchh-website
53
1
Fork 0
Code Issues 3 Pull requests 2 Actions Activity

Theme: Fix robots partial "isset on nil" warning #57

Merged
c6ristian merged 1 commit from fix/isset-warning into main 2024-04-20 18:15:05 +02:00
Conversation 1 Commits 1 Files changed 1 +1 -1
jtbx commented 2024-04-17 20:22:09 +02:00
Owner
Copy link

As not all pages have the robots param defined, we got a warning:

WARN  calling IsSet with unsupported type "invalid" (<nil>) will always return false.

This is solved by adding an additional "isset" check.

As not all pages have the robots param defined, we got a warning: ``` WARN calling IsSet with unsupported type "invalid" (<nil>) will always return false. ``` This is solved by adding an additional "isset" check.
jtbx added 1 commit 2024-04-17 20:22:09 +02:00
Theme: Fix robots partial "isset on nil" warning
All checks were successful
/ build (pull_request) Successful in 43s
Details
d9fd1381b9 
As not all pages have the robots param defined, we got a warning:
WARN  calling IsSet with unsupported type "invalid" (<nil>) will always return false.
This is solved by adding an additional "isset" check.
forgejo-actions commented 2024-04-17 20:22:22 +02:00
First-time contributor
Copy link

You can view your changes at https://staging.hamburg.ccc.de/pr57/

You can view your changes at https://staging.hamburg.ccc.de/pr57/
c6ristian approved these changes 2024-04-20 18:14:12 +02:00
Dismissed
c6ristian left a comment
Owner
Copy link

LGTM

LGTM
c6ristian force-pushed fix/isset-warning from d9fd1381b9 to 63d3f4459d 2024-04-20 18:14:43 +02:00 Compare
c6ristian approved these changes 2024-04-20 18:14:56 +02:00
c6ristian merged commit 63d3f4459d into main 2024-04-20 18:15:05 +02:00
c6ristian deleted branch fix/isset-warning 2024-04-20 18:15:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
c6ristian
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: CCCHH/ccchh-website#57
No description provided.
Delete branch "fix/isset-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?