CCCHH/ccchh-website
CCCHH/ccchh-website
3
3
Fork 3
Code Issues 3 Pull requests 4 Activity Actions

Update Tür/Telefon #86

Merged
stb merged 1 commit from tuer-telefon into main 2025-07-23 14:05:44 +02:00
Conversation 4 Commits 1 Files changed 1 +3 -2
stb commented 2025-07-23 10:54:23 +02:00
Owner
Copy link
No description provided.
Update Tür/Telefon
All checks were successful
/ build (pull_request) Successful in 42s
Details
502a7e4055
forgejo-actions commented 2025-07-23 10:54:42 +02:00
Copy link

You can view your changes at https://staging.hamburg.ccc.de/pr86/

You can view your changes at https://staging.hamburg.ccc.de/pr86/
lilly approved these changes 2025-07-23 11:16:22 +02:00
Dismissed
jtbx requested changes 2025-07-23 11:35:25 +02:00
Dismissed
content/home/4-kontakt/index.md Outdated
@ -13,3 +13,1 @@
Da die Zwischentüren im Haus verschlossen sind, muss euch immer eine Person am Eingang abholen.
Am östlichen Eingang (siehe Markierung auf der Karte) ist dafür eine Klingel.
(Die Klingel ist aktuell verschwunden, bitte ruft einfach [+49 40 23830150](tel:+494023830150) an.)
Da die Zwischentüren im Haus verschlossen sind, muss euch immer eine Person am Eingang abholen. An allen Eingängen gibt es jeweils eine Türsprechstelle. Wählt einfach die 1337, und ihr werdet mit dem Club verbunden. Wenn das aus irgendeinem Grund nicht funktioniert, wählt einfach die [+49 40 23830150](tel:+494023830150) oder [+49 221 596191008](+49221596191008).
jtbx commented 2025-07-23 11:35:13 +02:00
Owner
Copy link

Why were the line breaks removed? It's standard markdown syntax, so a line break alone in the source won't lead to a line break in the HTML.

It just generates a larger diff than needed every time one sentence in the long line is edited. And it breaks with the style of the remaining files.

Why were the line breaks removed? It's standard markdown syntax, so a line break alone in the source won't lead to a line break in the HTML. It just generates a larger diff than needed every time one sentence in the long line is edited. And it breaks with the style of the remaining files.
stb commented 2025-07-23 13:01:15 +02:00
Author
Owner
Copy link

The other paragraphs don't have line breaks either. So this is a really important objection? WFT.

The other paragraphs don't have line breaks either. So this is a really important objection? WFT.
jtbx commented 2025-07-23 13:14:32 +02:00
Owner
Copy link

The other paragraphs don't have line breaks either.

I only found one paragraph which doesn't at the whole home page (besides the blog posts). And that's also something where you changed the format from what it was to a single line. So I can't really follow why this is an argument.

And why is it a "WFT" to remind people to follow the existing coding style to have a somewhat consistent thing. How should new people understand how it's supposed to be when every line is differently formatted? Would you also accept that in some code?

> The other paragraphs don't have line breaks either. I only found one paragraph which doesn't at the whole home page (besides the blog posts). And that's also something where you changed the format from what it was to a single line. So I can't really follow why this is an argument. And why is it a "WFT" to remind people to follow the existing coding style to have a somewhat consistent thing. How should new people understand how it's supposed to be when every line is differently formatted? Would you also accept that in some code?
june commented 2025-07-23 15:25:41 +02:00
Owner
Copy link

Having each line on a new line also makes future diffs a ton more readable, so I think that's something we should strive for.

Having each line on a new line also makes future diffs a ton more readable, so I think that's something we should strive for.
jtbx force-pushed tuer-telefon from 502a7e4055 to 8f46b942fb 2025-07-23 13:22:23 +02:00 Compare
jtbx dismissed lilly's review 2025-07-23 13:22:23 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jtbx approved these changes 2025-07-23 13:23:10 +02:00
stb merged commit 714014bc25 into main 2025-07-23 14:05:44 +02:00
stb deleted branch tuer-telefon 2025-07-23 14:05:45 +02:00
stb referenced this pull request from a commit 2025-07-23 14:05:45 +02:00
Update Tür/Telefon (#86)
Sign in to join this conversation.
Reviewers
No reviewers
jtbx
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: CCCHH/ccchh-website#86
No description provided.
Delete branch "tuer-telefon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?