CCCHH/hedgedoc-expire
0
0
Fork 1
Code Issues Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Various Improvements and Changes #1

Open
june wants to merge 9 commits from june/hedgedoc-expire:patches into main
pull from: june/hedgedoc-expire:patches
merge into: CCCHH:main
Conversation 0 Commits 9 Files changed 6 +300 -142
june commented 2024-12-09 21:23:08 +01:00
Owner
Copy link

Some changes as part of my work:

  • make the docker image build work
  • make the arguments -r and -n not have defaults and therefore allow only acting on revisions or notes
  • switch to a more well-known postgresql library
  • add logic for removing deleted notes from the users history (shown on the Hedgedocs main page)
  • allow not setting an SMTP username and password
  • improve documentation a bit

And then bump to a new version with all these changes.

Some changes as part of my work: - make the docker image build work - make the arguments `-r` and `-n` not have defaults and therefore allow only acting on revisions or notes - switch to a more well-known postgresql library - add logic for removing deleted notes from the users history (shown on the Hedgedocs main page) - allow not setting an SMTP username and password - improve documentation a bit And then bump to a new version with all these changes.
june added 9 commits 2024-12-09 21:23:09 +01:00 
- Depend on a python version Debian actually ships with in
  pyproject.toml and update the poetry.lock accordingly.
- Fix poetry bundle complaining about no python by installing
  python-is-python3.
  Also remove the python flag for poetry bundle then.
This is useful, if one just wants to either expire notes or revisions.
Switch to a library which is more well-known.
I also thought the library was the problem for not being able to
template in a JSON path, but that is just a PostgreSQL problem it seems.
And then only act on notes/revisions, if the relevant argument got
specified.
This makes the CLI cleaner.
For the README:
- Improve the format, getting rid of the textwidth-based linebreaks and
  instead putting each sentence on its own line.
- Have an example for a local check execution to have the examples be
  more diverse.
- Describe the docker compose example and have it be up-to-date.
- Better describe the local setup example.
- Reformat the section on commands and arguments, first describing the
  commands and then the arguments, as this makes more sense
  structurally.
- Also change the title of the arguments and environment variables
  section to reflect its content on commands.

For the help output mirror the command descriptions of the README and
improve the format.
stb was assigned by june 2024-12-09 21:23:33 +01:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u patches:june-patches
git checkout june-patches

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff june-patches
git checkout june-patches
git rebase main
git checkout main
git merge --ff-only june-patches
git checkout june-patches
git rebase main
git checkout main
git merge --no-ff june-patches
git checkout main
git merge --squash june-patches
git checkout main
git merge --ff-only june-patches
git checkout main
git merge june-patches
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
stb
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: CCCHH/hedgedoc-expire#1
No description provided.
Delete branch "june/hedgedoc-expire:patches"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?