Add just the refactoring from #26. #32

Merged
stb merged 2 commits from refactor into main 2026-07-21 21:22:20 +02:00
Owner

This is based off #31, so that needs to be merged first.

This is based off #31, so that needs to be merged first.
Add just the testing setup from #26.
All checks were successful
/ Verify (pull_request) Successful in 1m12s
/ Verify (push) Successful in 53s
f204ab7f28
Important: there are changes here to adapt the tests and the Keycloak test realm that are incompatible with the changes in #29. Ultimately, the changes in #29 need to be applied over this.
Add just the refactoring from #26.
All checks were successful
/ Verify (pull_request) Successful in 48s
e5d68bb9ad
This is based off #31, so that needs to be merged first.
stb force-pushed refactor from e5d68bb9ad
All checks were successful
/ Verify (pull_request) Successful in 48s
to 218ee1dd57
All checks were successful
/ Verify (pull_request) Successful in 45s
2026-07-19 13:22:06 +02:00
Compare
stb referenced this pull request from a commit 2026-07-19 13:38:27 +02:00
june requested changes 2026-07-21 21:17:44 +02:00
Dismissed
@ -149,0 +90,4 @@
throw new NotFoundException("Endpoint not found");
}
if (componentList.size() > 1) {
Owner

Einrückung fehlt.

Einrückung fehlt.
june marked this conversation as resolved
@ -149,0 +87,4 @@
.toList();
if (componentList.isEmpty()) {
throw new NotFoundException("Endpoint not found");
Owner

Missing dot.

Missing dot.
june marked this conversation as resolved
Formatting
All checks were successful
/ Verify (pull_request) Successful in 52s
/ Verify (push) Successful in 46s
510c045070
june approved these changes 2026-07-21 21:20:45 +02:00
june left a comment

Looks good!

Looks good!
stb merged commit 510c045070 into main 2026-07-21 21:22:20 +02:00
stb deleted branch refactor 2026-07-21 21:22:20 +02:00
stb referenced this pull request from a commit 2026-07-21 21:24:55 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
CCCHH/keycloak-attribute-endpoints-provider!32
No description provided.