CCCHH/spaceapid
CCCHH/spaceapid
54
2
Fork 0
Code Issues 6 Pull requests 1 Packages Projects Releases 1 Activity

Refactoring #34

Merged
bendodroid merged 10 commits from :Bendodroid-refactoring into main 2024-05-26 21:06:30 +02:00
Conversation 1 Commits 10 Files changed 17 +197 -150
bendodroid commented 2024-02-13 19:58:25 +01:00
Member
Copy link
  • Rename go module
  • URL paths for sensors are now always registered without trailing slash, the HTTP 301 handling in curl and elsewhere for PUT requests is a f-ing joke, I am not dealing with this. This will require changes in clients probably.
  • Move persistent state code to own package and compile platform-specific path for linux. Might add a cli flag in the future, not sure.
  • Add omitempty to struct fields to account for beverage_supply sensor
  • Update README

Fixes #27 #30

- Rename go module - URL paths for sensors are now always registered without trailing slash, the HTTP 301 handling in curl and elsewhere for PUT requests is a f-ing joke, I am not dealing with this. This will require changes in clients probably. - Move persistent state code to own package and compile platform-specific path for linux. Might add a cli flag in the future, not sure. - Add omitempty to struct fields to account for `beverage_supply` sensor - Update README Fixes #27 #30
bendodroid added the
is:breakingChange
cat:refactoring
 labels 2024-02-13 19:58:25 +01:00
bendodroid added 10 commits 2024-02-13 19:58:26 +01:00
bendodroid requested review from june 2024-02-13 20:06:42 +01:00
bendodroid force-pushed Bendodroid-refactoring from 4a5270092c to b98174c7da 2024-05-26 20:52:37 +02:00 Compare
bendodroid commented 2024-05-26 21:02:55 +02:00
Author
Member
Copy link

I don't think anyone will review this, merging this without review... 🤷‍♂️

I don't think anyone will review this, merging this without review... 🤷‍♂️
bendodroid merged commit b98174c7da into main 2024-05-26 21:06:30 +02:00
bendodroid deleted branch Bendodroid-refactoring 2024-05-26 21:06:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
june
Labels
Clear labels   
cat:refactoring

   
cat:security

   
cat:tooling

   
is:breakingChange

   
is:bug

   
is:feature

   
is:idea

   
is:postponed

   
res:wontfix
No labels
cat:refactoring
cat:security
cat:tooling
is:breakingChange
is:bug
is:feature
is:idea
is:postponed
res:wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: CCCHH/spaceapid#34
No description provided.
Delete branch ":Bendodroid-refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?