• Germany & Cyberspace
  • Does infrastructure crimes with Nix and Ansible.

  • Joined on 2024-01-14
june suggested changes for CCCHH/ansible-infra#129 2026-07-29 13:10:56 +02:00
add dooris role for setup of dooris interaction on the node itself

Thanks for the changes, looks good! Just two notes.

june commented on pull request CCCHH/ansible-infra#129 2026-07-29 13:10:56 +02:00
add dooris role for setup of dooris interaction on the node itself

This should probably use dooris__hostname.

june commented on pull request CCCHH/ansible-infra#129 2026-07-29 13:10:56 +02:00
add dooris role for setup of dooris interaction on the node itself

Having those be hardcoded with all else being configurable is a bit awkward, so I think making these variables as well make sense.

june approved CCCHH/ansible-infra#112 2026-07-22 21:50:22 +02:00
alloy(role): pull in alloy role that works from fux

Nice, let's go!

june approved CCCHH/keycloak-attribute-endpoints-p...#30 2026-07-21 22:17:24 +02:00
default-to-user-email

Nice!

june commented on pull request CCCHH/keycloak-attribute-endpoints-p...#26 2026-07-21 21:45:08 +02:00
Add exporting individual attributes and a map endpoint

Let's have a comment here to note that we leave this name for backwards compatibility.

june commented on pull request CCCHH/keycloak-attribute-endpoints-p...#26 2026-07-21 21:45:08 +02:00
Add exporting individual attributes and a map endpoint

"The selection of attributes and authorization is managed through an endpoint configuration via the admin UI."

june commented on pull request CCCHH/keycloak-attribute-endpoints-p...#32 2026-07-21 21:17:44 +02:00
Add just the refactoring from #26.

Einrückung fehlt.

june commented on pull request CCCHH/keycloak-attribute-endpoints-p...#32 2026-07-21 21:17:44 +02:00
Add just the refactoring from #26.

Missing dot.

june commented on pull request CCCHH/keycloak-attribute-endpoints-p...#31 2026-07-21 21:03:08 +02:00
Add just the testing setup from #26.

Looks good!

june commented on pull request CCCHH/ansible-infra#129 2026-07-19 18:03:31 +02:00
add dooris role for setup of dooris interaction on the node itself

Please add another underscore between role name and variable name to match the convention used in the other roles (so dooris__static_api_token).

june commented on pull request CCCHH/ansible-infra#129 2026-07-19 18:03:31 +02:00
add dooris role for setup of dooris interaction on the node itself

Same here (so dooris__url).

june suggested changes for CCCHH/ansible-infra#129 2026-07-19 18:03:31 +02:00
add dooris role for setup of dooris interaction on the node itself

This looks good!

june suggested changes for CCCHH/ansible-infra#112 2026-07-18 00:43:47 +02:00
alloy(role): pull in alloy role that works from fux

Oops, should have been a request changes :D

june approved CCCHH/ansible-infra#112 2026-07-18 00:43:22 +02:00
alloy(role): pull in alloy role that works from fux

Awesome! Just the removing the tag remaining in the main.yaml and then we can merge this. :3