Theme: Fix doubled "Neuigkeiten" on start page, differentiate events from articles more #159
stb
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/home-double-news-heading"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The start page was displaying two "Neuigkeiten" headings when both an event and an article should have been displayed on the start page at the same time. This looks broken.
With this PR the heading is only displayed once. To be able to distinguish a bit more easily between events and articles, the latter got a "newspaper" icon and have no time in the date any more.
I also increased the time an article is displayed at the front page from roughly 1 day to 5 days (and 6 hours).
You can view your changes at https://staging.hamburg.ccc.de/pr159/
Looks to me like the two lists are now almost identical with differences only in the $list that goes into the range, and different behaviour in the blog-headers partial, which is already shared.
I think combining $upcoming and $articleNew would not only combine both types into one list, fix the core issue of duplication, but also it would sort events and articles by the same key, currently they are just plainly appended, internally sorted.
Proposed solution for above comment at feat/home-double-news-heading-2. @jtbx
Schaue ich mir morgen oder spätestens am Wochenende an. Bin gerade gedanklich in meinem anderen Projekt.
You're not 100% correct here: As currently proposed there will be a list of upcoming events sorted by date first and then some articles (also sorted by date). And I kinda like that events are shown before articles since they are more important in my opinion.
When both lists are combined an "old" article may be above the event tomorrow however for example.
I would even reverse the article order so that the newest will be first (since they are all in the past compared to events which are in the future). EDIT: See latest commit (validated it locally and works as intended)
Does it make sense to remove the date on articles on the home page/the blog index page? That would differentiate them more from event announcements. Also a different background color might be nice. They still look very similar I think.
On the home page: Maybe.
On the blog (https://staging.hamburg.ccc.de/pr159/blog/ and https://staging.hamburg.ccc.de/pr159/categories/article/): I thought about it and it looked really weird. And I would definitely like to know the publishing date when going through the pages.
56c5e4130a3b5e0bec9aI think the date is not really that relevant, as long as we keep posting articles, and I would see it as part of the article page.
3b5e0bec9a2c642a0a302c642a0a30cf04a87072cf04a870723df895f734lgtm